[Next Update] Revelation Dance not changing type

Discussion in 'Solved Bugs' started by Funbot28, Mar 9, 2017.

  1. Funbot28

    Funbot28 Active Member

    Joined:
    May 17, 2015
    Messages:
    253
    Likes Received:
    98
    Client Type (ex. PC, Android, Webclient): PC

    Client Version (if known. Webclient has no version.): Webclient

    When did you first notice the bug?: Today

    Have you been able to reproduce the bug?: Yes

    Information (include relevant logs, replays, screenshots):

    Battle between funbot and Nicko just started!

    Mode: Singles

    Tier: SM Balanced Hackmons
    Variation: 23, -47
    Rule: Rated
    Rule: Team Preview
    Rule: Self-KO Clause

    Your team: Giratina / Mega Gengar / Mega Tyranitar / Primal Kyogre / Primal Groudon / Mega Rayquaza
    Opponent's team: Gardevoir

    funbot sent out Mega Gengar!
    Nicko sent out Gardevoir!
    Turn 1
    Nicko's Gardevoir has Mega Evolved into Mega Gardevoir!
    Mega Gengar used Revelation Dance!
    Nicko's Gardevoir lost 32% of its health!

    Nicko's Gardevoir used Draining Kiss!
    It's not very effective...
    Mega Gengar lost 45 HP! (13% of its health)!
    Mega Gengar had its energy drained!

    Turn 2
    Mega Gengar used Revelation Dance!
    Nicko's Gardevoir lost 36% of its health!

    Nicko's Gardevoir used Draining Kiss!
    It's not very effective...
    Mega Gengar lost 41 HP! (12% of its health)!
    Mega Gengar had its energy drained!

    Turn 3
    Mega Gengar used Shell Smash!
    Mega Gengar's Defense fell!
    Mega Gengar's Sp. Def. fell!
    Mega Gengar's Attack sharply rose!
    Mega Gengar's Sp. Att. sharply rose!
    Mega Gengar's Speed sharply rose!

    Nicko's Gardevoir used Hyper Voice!
    It's not very effective...
    Mega Gengar lost 132 HP! (40% of its health)!

    Turn 4
    Mega Gengar used Judgment!
    It's not very effective...
    Nicko's Gardevoir lost 18% of its health!

    Nicko's Gardevoir used Draining Kiss!
    It's not very effective...
    Mega Gengar lost 57 HP! (17% of its health)!
    Mega Gengar had its energy drained!

    Turn 5
    Mega Gengar used Revelation Dance!
    Nicko's Gardevoir lost 50% of its health!
    Nicko's Gardevoir fainted!

    funbot won the battle!
    Nicko: Don't stop please...

    The move was supposed to hit Mega Gardevoir SE because it is supposed to change to a Ghost type move

    (If applicable) Sources to confirm the presence of a bug (ex. Smogon): It works on Smogon lol
     
  2. fsk

    fsk Woke up after a long dream Forum Moderator Server Moderator Forum Moderator Server Moderator

    Joined:
    Jan 15, 2016
    Messages:
    292
    Likes Received:
    349
    PO Trainer Name:
    fsk
    Can confirm this needs a fix.
    Welp, I am just being busy and lazy recently, so just note to self that I need to test some stuff. If @Funbot28 you actually figured out and tested the following feel free to update the OP. I will go over testing these on our sim otherwise.
    facts confirmed in game that needs testing on our sim:
    1. The type of Revelation Dance always matches the user's primary type. [BUGGED]
    2.
    If a Pokémon has lost its primary Fire type due to Burn Up, Revelation Dance's type will match its current type: its secondary type if it has any, or else the type added by Forest's Curse or Trick-or-Treat if it has any, or else have no type (in which case Revelation Dance will not receive STAB). [Should be working as the code does a check like this]

    3. If a Pokémon has lost its primary Flying type due to having used Roost earlier this turn (and uses Revelation Dance due to its Dancer Ability), Revelation Dance's type will match its current type: its secondary type if it has any, or else be Normal-type (regardless of type additions by Forest's Curse or Trick-or-Treat).

    4. Revelation Dance is unaffected by Normalize, Pixilate, Refrigerate, Aerilate, and Galvanize. However, it is affected by Ion Deluge (if the move would be Normal-type) and Electrify.
    5. Typeless Revelation Dance does not activate Color Change and is blocked by Wonder Guard. Conversion 2 will fail if the last move used by the target is typeless Revelation Dance.
    6. Regardless of the user's types, Revelation Dance is always treated as Normal-type for Z-Move mechanics, and can be upgraded to Breakneck Blitz by a Normalium Z.
    7. Revelation Dance copied off Mirror Move is the Mirror Move User's type.
     
    Last edited: May 19, 2017
  3. fsk

    fsk Woke up after a long dream Forum Moderator Server Moderator Forum Moderator Server Moderator

    Joined:
    Jan 15, 2016
    Messages:
    292
    Likes Received:
    349
    PO Trainer Name:
    fsk
    https://github.com/po-devs/pokemon-online/pull/1652
    Pull Requested a fix for the type changing interaction with Normalize, Aerilate and duplicates with the help of VP, waiting someone to test/merge.

    Edit: Merged by fuzzy, assuming this part will be fixed with next server restart.

    There are some other remaining bugs that is less relevant competitively outlined in my post above, but I guess that would still keep this thread marked as unfixed.
     
    Last edited: May 23, 2017
    Funbot28 likes this.