Mafia Review Themer Guidelines / Posting Guidelines

Discussion in 'Review' started by Roild, Dec 10, 2013.

Thread Status:
Not open for further replies.
  1. Roild

    Roild Member

    Joined:
    Jul 21, 2012
    Messages:
    861
    Likes Received:
    11
    PO Trainer Name:
    Roild
    The Mafia Quality Control Team, or QC for short, is the group that review themes to make sure they meet a level of quality before being admitted into the server. Of all the members, five of them will be chosen for each theme according to schedules and strengths. From there, those 5 will review normally. Any QC member may review if they wish to make a point, but only those 5 will be able to accept, decline, or test the theme. This is so each theme will have a strong sampling of QC and different view points. During the course of the week, each member will make points about the theme until the theme achieves a majority accept or rejection.


    Mafia QC members are expected to maintain a professional appearance, therefore, certain types of behavior is prohibited.
    All reviews should be done based on the theme itself, not the author.
    All posts are expected to be constructive and help the theme author improve. Constructive criticism is allowed, but criticizing without offering suggestions is not.
    All QC are expected to post their own thoughts and ideas about the theme, not just repeating someone else's thoughts.
    A theme should be judged on all factors, including (but not limited to): game balance, ease of learning, unique features, and popularity. A popular theme might be terribly balanced, but a really balanced theme might be impossible to learn or hardly played. Suggestions should be aimed at balancing everything to a point of success.

    What happens if a QC is not doing their job properly? In the event of a QC member not reviewing, they will be confronted by the Lead QC or sMA in order to correct the issue. In the event this does not correct the behavior, the QC member may be terminated at any point in favor of a replacement.


    If you, as a theme author, have any problem with any QC outside of activity, then contact Fuzzy and Beast in order for the situation to be resolved.

    How do you place a theme up for review? What are some requirements for a theme?
    A set of required guidelines must be followed when posting your theme. Failure to comply with the rules for putting a theme up for review can lead to consequences ranging from immediate rejection of the theme, to restrictions on posting in the section, to forum infractions.

    Must be valid JSON code. Recommended sites are JSONLint or JSON Formatter & Validator.
    Must include a confirmation the theme has no errors affecting gameplay using RiceKirby's Mafia Theme checker.
    Must include a RAW Link to the coding using Pastebin, Dropbox, Github, or any other site with RAW capability.
    Should pay attention to correct spelling and grammar.
    Should be able to accommodate around 40 players. (Nonpeak themes should not accommodate more than 12 players).
    Must follow a format for submission in order to streamline the process.

    Pictures in a thread should be limited. Excessive use is generally negative to the actual thread. Use some common sense as to what is needed and what isn't.

    Link to your code. Please do not use a spoiler tag here. Also, you no longer need to post your entire code into your post as it is a pain to keep it updated, and some themes are really long.

    Basic Summary of your theme should be next. You want to sell your theme to the community. Explain unique perks or concepts used in the theme or anything that helps with teaching your theme. Please do not use a spoiler tag on this either.

    Roles:
    [you can use a spoiler here]
    List out each role, BY HAND. Roles are more complex than they look in the theme checker. Anyone can take the theme and put it in the checker and see what the output is. This doesn't tell us what each role does. For example:

    Vigilante: Has a Kill that can be used three times per game. If it kills a village sided role, it is unable to kill the following night.

    Tell us how each role interacts with each other. This makes reviewing much easier. You're the one who created the code, so you should let us know what you know in order to accurately review
    [closing spoiler tag]

    Spawn break down:
    [you can use a spoiler here]
    Tell us a basic breakdown of your spawn. Pick some key set ups and explain the breakdown of how many mafia there are, how many village roles, etc. Every time you change to a new roles list, you should list out changes. If you're unable to pick key points, then just do every 5-10 players. For example:

    At 17 players, two villagers get replaced by a non revealing samurai and a generic mafia. This breaks down to 10 village roles (3 villagers and 7 PRs) versus 7 Mafia (Team of 3, Team of 3, and a Solo Mafia)
    [closing spoiler tag]

    Priority:
    [you can use a spoiler here]
    You can copy the priority list directly from the theme checker. This helps make sure actions are in the correct order.
    [closing spoiler tag]

    Finally, include anything else you'd like us to know. Suggestions or ideas for the future, places you might be concerned about, and so on. If you tell us something like "I'm unsure if the balance around 15 players is good," then we know to look at that area and give suggestions. If you put an idea for a change, then we can review that change and help you decide what to do.[/spoiler ]


    What is an "Approve"/"Decline"/"Test" post?

    An approve means the QC that reviewed your theme thinks it is up to par with server standards. An approval is only considered valid if the approval post is accompanied by a review of the specific theme.
    A decline means the QC that reviewed your theme thinks it is not up to par with server standards. A decline is only considered valid if the declination post is accompanied by a criticism of the faults of the theme.
    A test means the QC that is in the process of reviewing your theme needs to see it in action to accurately pass judgement. A test is only considered valid if the testing post is accompanied with a reason for requesting the test.

    A valid post is up to the discretion of the Lead QC and the Super Mafia Admins. For the purpose of reviewing, a "judgement post" is the collection of all replies to the thread by that particular QC member. If adequate reasoning is given before the judgement is decided, then it counts the same as if it is all done in one post. All judgement posts should have the Approve, Decline, or Test phrase bolded and numbered to improve speed of processing.

    How does a theme get approved or declined?

    For a theme to be approved, it must have at least three (3) QC members, from the assigned group, approve it. This will result in a more rigorous QC process and only themes that meet the quality standard will make it onto the server.
    For a theme to be declined, it must have at least three (3) QC members, from the assigned group, to decline it. This will also contribute to a higher standard of themes that make it onto the server.
    If at any time the amount of members on the squad change, the format for adjusted review count has Decline at a simple majority, and Approve being the number required for decline plus one.

    What is a testing period?
    The testing period for any theme is a period of one week for a standard theme. Non-peak themes will get an adjusted testing period based on server activity. During this period, game logs should be copied and posted in the theme's review thread so any QC member not online during that time can see the theme in action. It is up to the author to keep track of their theme so that the QC may review properly.

    In the event a theme finishes testing, and there is still doubt about the theme, or the theme undergoes some overhauling during or after testing, a retest period or extension on the testing period may be called. Extensions and retests will be dealt with on a case by case basis as no two situations are alike.


    What happens if a theme gets locked up in voting?
    If one of the theme reviewers is not around to finish voting (something came up), then another QC member will be chosen to take their place.

    What happens if a QC member, or members, make a theme?
    In the event a QC member, or members, make a theme, then the theme will be assigned to other QC members who are not authors and will be treated as a normal review.

    How does a theme get disabled or removed?
    In order to qualify for removal, the theme must be out of review for no less than 30 days. To start the removal process, there must be an issue with the theme brought up that has been ignored by the theme author. Only sMAs can start the actual removal process.
    Upon the posting of this issue, only Lead QC or sMAs may disable the theme if the issue is large enough to affect normal game play. An emergency disable may be performed by any MA, to be latter reaffirmed by a Lead QC or sMA, if the theme is very broken, such as a role or side being physically unable to lose a game, or a role broken enough that it majorly affects game play. All disables will be logged by whoever performs it. If an emergency disable has been performed, and the theme author is active, they have a window of time to fix the issue before removal procedures start. Upon resolution of the problem, the theme author may contact any MA to re-enable the theme. All enables will be logged by whoever performs it.

    Once the removal process begins, it can be cancelled at any time if the theme author provides reasonable accommodations to solve the issues in the theme. The removal process works like the reviewing process, however, all QC may participate in the process. Each person wishing for the theme to be removed must post their reasoning behind their opinions, as well as solutions to solve some or all of the issues presented. Once five (5) QC members have called for removal, the theme will be removed and forced to be reviewed again in order for it to be re-added to the server. To prevent a mass swarm voting for removal, there will be a required 12 hour block between each removal vote, however, the first one may occur immediately after the theme is placed for removal. Any QC who does not want the theme to be removed can either post with their reasoning directed at refuting the points of the removal arguments, or simply abstain from commenting and voting. If at any time a theme cannot possibly get five (5) QC members to call for removal, the theme will be re-enabled on the server and it will be considered up to standard.

    What happens if a theme author abandons a theme?

    A theme may be adopted only under specific circumstances. After 30 days, the theme's code may be changed to fix small problems. A theme author may place their theme up for adoption at any time after it is placed in review. A theme removed via a removal vote without an active author is placed up for adoption as well. If a theme's author has not been on in 60 days, the theme is considered abandoned and placed up for adoption. Finally, if a theme is in review for over 60 days with no updates, the theme will be automatically declined for non-pursuance.

    An adopted theme only has to go through review if the underlying structure of the theme has been changed. If only specific roles that caused a problem were changed, or the adoption was to help maintain the theme, a review is not necessary. If the main structure of the theme has been altered, a review may be required. The restructured theme must be submitted to review as if it were a new theme and gets the same treatment.

    In the event the original author returns after the theme has been adopted, it is recommended for the current owner and the original owner to work together to produce a better theme. In the event of a conflict, the current owner will keep possession of the theme since it was considered abandoned beforehand.


    If a QC is forgetting to review, don't be afraid to talk to them to see what the problem is. Or anyone who can talk to them. It may happen that it just slips their mind.


    Who are the current Mafia QC?


    QC:
    No one!

    Test QC members have the same rights as normal members, but only one or two of them will be part of a theme review until they become full QC members.
    Clan war, free-for-all, and non-competitive themes follow different rules from normal village setups. I'll address each separately.

    Free-for-all: This is something that will not be accepted in Mafia. A theme should not have every player trying to kill most/all other players.

    Clan wars: A clan war involves different groups (2+) of similar powers. Not necessarily equivalent to each other, so they can specialize in different things. There may be a common enemy as well with more power than any individual can handle. Since a clan war involves an uninformed minorities vs other uninformed minorities, they are generally acceptable for Mafia. Clan wars which are only concerned with killing everyone mostly fall under free-for-all and will most likely not be accepted.

    Non-competitive themes: This can be an excessive number of things. Essentially any theme that has a point other than removing other players. May also be called gimmicks. It would depend on a case-by-case situation, but most of these types are not well received.

    If I forgot anything, point it out for me.

    Theme can be taken down due to lack of play or any other reason the sMAs see the theme being unfit at any time. We are fair about stuff though and there is no bias.

    Don't ask to be QC, it is offered to those who are qualified!
     
    Last edited by a moderator: Aug 11, 2014
  2. Beast

    Beast I do what I want

    Joined:
    Sep 7, 2012
    Messages:
    925
    Likes Received:
    31
    Change Log:

    December 9, 2013- Creation of thread.
    February 4, 2014- Adjusted group assignments.
    March 20, 2014- sMAs can take down themes
    May 17, 2014 - arbitrary date when stuff happened
    June 29, 2014 - *coughs*
    July 24, 2014 - Added a new rule.
     
    Last edited: Jul 25, 2014
  3. Roild

    Roild Member

    Joined:
    Jul 21, 2012
    Messages:
    861
    Likes Received:
    11
    PO Trainer Name:
    Roild
    This section will state who is assigned to what theme. Since some themes have already been partly reviewed, the votes needed will be calculated with past votes. Themes have a week of being in testing until disabled.

    TBA!
     
    Last edited: Aug 25, 2014
  4. Windblown

    Windblown sable knight

    Joined:
    Aug 12, 2012
    Messages:
    841
    Likes Received:
    169
    Since @Roild has been out of commission for a while I'm interim head QC, so if you get any orders from me know that I'm actually doing it because I can and I'm not being bossy lo!l

    New QC assignments
    @Sky Sentinel, @Pandaofazn, @Pangaea, @Whereabouts Unknown , @Fiery Espeon to Time - cancelled
    Myself, @Paradoxial, @canterbury egg, @Shazan , @MewtwoHidden to Hetalia
    @Paradoxial to Mario
    @EljayQuiz to Narcotics
    @Fiery Espeon, @RudeStyle, @Sky Sentinel, @Nitrogen, @Pandaofazn to Madoka
    @Sky Sentinel, @Pangaea, @Withoutatrace, @canterbury egg, @EljayQuiz to Zombies
    @Karp Karpity, @MewtwoHidden, @Shazan, @canterbury egg, myself on Shop

    @Karp Karpity is test QC now!

    Themes still in review: Mario (testing), Narcotics (retesting), Types

    Right now we don't really need much distribution, just for QC to actually man up and get some accepts/declines/tests through
     
    Last edited: Aug 9, 2014
  5. Beast

    Beast I do what I want

    Joined:
    Sep 7, 2012
    Messages:
    925
    Likes Received:
    31
    New Rule:

    Don't ask for QC. If you deserve it we will know and you will be offered it.

    First post will reflect.
     
  6. Yttrium

    Yttrium Well-Known Member Developer Developer

    Joined:
    Sep 29, 2010
    Messages:
    619
    Likes Received:
    283
    PO Trainer Name:
    Yttrium
    What happened here?
     
  7. Fuzzysqurl

    Fuzzysqurl baa baa mareep I do what I want Server Owner Developer I do what I want Server Owner Developer

    Joined:
    Sep 12, 2012
    Messages:
    2,096
    Likes Received:
    967
    QC is officially shut down as of now. It will be reopening shortly... hopefully 3rd time is the charm here. I could really live without having to do this every couple of months.

    All approves and declines are (rip) now void and no more can be handed out cause no one is QC! Please continue to discuss themes as normal to try to work out issues so when QC comes back, we can process the themes quickly.
     
Thread Status:
Not open for further replies.