Yes, that's something I need to add to the Checker. I actually had that same error myself with Medieval. I'll add that to the checker whenever I get some time.
Best way to contact you I suppose: If you hide an action from priority, it will still show in the Theme Checker. Is there a way you can either make it so you can toggle hidden on and off, or formatting hidden things with a lighter color (like a grey instead of black)
help :x So I put my theme into the checker and it said everything was alright. No fatal or minor errors. Yet, when I test the theme out, I get this: (17:17:00) Times Up! : (17:17:00) ±Game: Your target (Roild) has been converted and is now a Pirate's Hostage! (17:17:00) Error occurred in mafia while handling the end of 'night' phase: TypeError: Result of expression 'player.role.actions.night' [undefined] is not an object. I'm not sure what to do from here... Theme pastebin: Spoiler http://pastebin.com/raw.php?i=HdLvW1bb[/HIDE]
Spoiler A full game log + readlog would help. I can't tell what's wrong only by that. In any case, I think that's actually a Mafia Script bug, but I can't find the error without further information.
I assume it has to do with the lines of code: "convertmsg": "~Old~ has become the ~New~!", "silent": true, In the Pirate Crewman's "capture" command.
Thank you for the reply, but I figured it out. My capture and rescue were conflicting when two people tried to capture/rescue the same person on the same night. :) Fuzzysqurl helped. :D
I'm planning to add a function to check for bad commands (as in, commands that shouldn't be used in a mafia theme, such as "slay" or "kick") that can conflict with server/channel commands, but I'll need some help making that list. What I have so far (will try to keep this list up-to-date): Spoiler commands start votetheme starttheme help roles sides myrole mafiarules themes themeinfo changelog details priority flashme playedgames update join unjoin mafiaadmins mafiaban mafiaunban passma mafiaadmin mafiaadminoff mafiasadmin mafiasuperadmin mafiasadminoff mafiasuperadminoff push slay shove end readlog add remove disable enable updateafter importold mafiaban mafiaunban mafiabans detained detainlist Some of those commands would probably not disrupt the game if used in the proper phase, and some other would hardly make it to a mafia theme, but list them anyway :x If you remember any command I missed, just post here.
Spoiler http://pastebin.com/raw.php?i=2HTXpDWg[/HIDE] When i first tested my theme it worked perfectly in both JSOLint and your checker Now JSOLint is fine but your checker says i got misformed JSOL.. WHICH ISNT TRUE :D
Requesting a whitelist the string "daykillevademsg" under the "actions" tree. http://pokemon-online.eu/forums/sho...-Documentation&p=297612&viewfull=1#post297612 Optional message, yadda yadda.
Requesting whitelist on optional messages: role.actions.daykillmissmsg role.actions.daykill.mode.evasionmsg role.actions.standby.expose.exposedtargetmsg I think only the first 2 actually trigger a minor error, but adding all 3 never hurts. http://pokemon-online.eu/forums/sho...-Documentation&p=298863&viewfull=1#post298863 ~~~~~~ Under role.actions: expose: Can be "evade", "revealexposer", "revenge" revealexposermsg exposerevengemsg exposeevademsg exposemissmsg startup: team-revealif-with-roles Under roles.actions.expose: exposedtargetmsgUnder roles.actions.daykill.mode: ignore (then array of roles) msg Under roles.actions.expose.mode:evadeChance evasionmsg ignore (then array of roles) msg That should be all. Most of them are just optional messages. Essentially, take daykill and copy it for expose... minus the "bomb" mode. That was the only thing I didn't code because I couldnt find a logical reason for an exposee to die after getting exposed, causing the exposer to die too... http://pokemon-online.eu/forums/sho...-Themes-(v2-0)&p=299752&viewfull=1#post299752
I think I added everything, but I don't have a theme to test the new stuff, so please report any error :x Also, maybe I should remake the checker code, as it's getting harder to update :x
I'll check the daykill evade right now, lol. Soren (soren) Help Text: You're the expert tactician of the Greil Mercenaries. You're very loyal to Ike and serve him with your life but are a bit...cold to other people. Regardless, its in your best interests to help the heroes and end this war. To this end, you have the ability to /inspect one unit at nighttime, showing their identity. You're also good at predicting traps and danger, giving you a 10% chance to not die to killers. You're always next to Ike so you know his identity. Abilities: Night Actions: Inspect: Has a 10% chance of evading kill. Knows Ike. Doesn't show that he evades Ike there... Minor errors found in your script: Role soren's "daykill" action has an extra attribute "targetmsg". "targetmsg" is the thing that gets sent to Soren, so yeah.
I only updated the Errors tab. The Roles Info are not updated yet. And there's no thing like targetmsg for daykill mode. You are probably thinking of evasionmsg.
It's for the daykill evade: Code (text): "daykill": { "mode": { "ignore": [ "ike" ] }, "targetmsg": "±Tactician: A giant, golden sword is seen high in the sky. You quickly moved out of the way to avoid being hit.", "msg": "±Tactician: Soren sidestepped the swing of your sword. 'Is there something you wanted to talk about, Ike?'" } } and trust me, it's right-- fuzzy and i spent hours trying to fix it...
There's no mention to any targetmsg anywhere near the daykill code. You are definitely mistaking the attribute name, or the code Fuzzy submitted is different from the one you tested.
I think since he's still working on it he didn't submit it yet... I'll get back to you later on that then, lol
targetmsg will go under mode for both daykill and expose. Also, whitelist "nonPeak" in the global theme area EDIT: Also add "onslay" to "onDeath" stuff. Its a boolean... if you want to update the Roles tab: Undefined or true = "When this user is slain, onDeath activates" False = "When this user is slain, nothing happens" (The way it is now)
It would be better ifonslay defaults to how it works currently. Besides, I added a note to the commit about how that won't work yet. And updated checker with a slightly revamped code. Most of the stuff is to make it easier to update later, but what users will notice is that lots of messages are different now, there are some extra checks and 2 new features: Check for bad command (commands like slay, ban, help, etc) and Case Check for some stuff (so the checker will warn when you have 'initialRecharge' instead of 'initialrecharge', for example).
Whitelist global attrtibutes: themelink altname Whitelist actions.lynch (Copied from onDeath, but there are situations where you want Lynch but cannot use onDeath. Like Vengeful.) exposeroles killroles curseroles convertroles poisonroles Also, the onslay thing was updated to work properly and such. Same placement though.
Everything added (I hope). Report if anything is missing/wrong. And again, only Errors tab updated for now. Will update the Roles tab later.
Ah, I meant to post awhile ago: Add Detox/Dispel to valid commands Both actions use 4 messages, ones that throw errors: failmsg targetmsg detoxmsg dispelmsg Add resistance to valid modes Related values: (They go in [action].mode, same place a msg would. If you could also note they need to be a valid integer/number) Rate Constant Default value if neither is defined is "Takes 1 additional night to die/get converted", for the Roles output Hide needs to accept values of "side", "role", "both", or be a valid boolean If you're up for it while you're adding, Curseattacker[evenifprotected] should be ready soon, its pretty much a clone of the night action Curse, with all the same options. If you don't get it added, I'll make a full list of what needs to be whitelisted once i get it working and added.
Oh right, I need to update the checker, but lazy ┐( ̄ー ̄)┌ Checking for errors is easy, the annoying part is to add stuff to the Roles tab Edit: Added stuff to Error check tab, including the Revenge Specific Standby action that you forgot to mention. Roles tab will be updated whenever I feel not lazy :x Roles Tab updated too.
Testing theme used: http://pastebin.com/hVuswgE5 votemsg as global attribute add "all" and "*" to broadcast
Hey, can you whitelist "tips" (sort of like "changelog")? It's nothing special, meaning I'm not expecting a command like /help or /myrole, but it could act as an incentive for people who've read the themes. Since it's a minor error, it gets discarded anyways, so it's pretty much hassle free, right? Code would go like this Code (text): "tips": { "Inspector": "Always claim if BG is alive!", "Bodyguard": "Always BG Inspector!" }
Jumping the gun here, this is for the pull request currently awaiting merging: https://github.com/Fuzzysqurl/Mafia/blob/master/Themes/Development/Test Fatal errors found in your script: No fatal errors found. Good job. Minor errors found in your script: Your role "villager" has an extra attribute "startupmsg". Role soren.actions.daykill has an extra attribute "expend". Role sophia.actions.expose has an extra attribute "expend". Role goon.actions.inspect has an extra attribute "seenSide". Daykill mode needs property "expend", which is a boolean Expose mode needs property "expend", which is a boolean Role needs "startupmsg" Actions.inspect needs "seenSide" (same place as "mode" is)
I tried to put a theme I created in the theme checker, but I believe it's bugged. It still says "checking your theme" after 45 minutes. Stocke also did a check for himself using the Vengeful theme, and he had the same problem. (You can ask him to confirm it.)
Try to clear the cache and reload the page (or use the full refresh, or private browsing). I made a structural change recently, so it's possible you are only loading the old script version.
I've been trying to use it as well. Cleared my cache and all saved things. It isn't working for me on Chrome. It keeps saying "Checking your theme, please wait". It is working on Firefox although I never use Firefox.
This is from a page breaking change in Chrome 27[?] - see https://code.google.com/p/chromium/issues/detail?id=180007 GitHub doesn't want you to include scripts from raw links by setting X-Content-Type-Options: nosniff This header is parsed in IE 8-10, so those are broken too. Gecko might implement it as well. Opera 15+ will/has the same 'problem' as Chrome. You can try serving from https://rawgithub.com/po-devs/po-server-goodies/master/scripts/mafiachecker.js instead (no rawgithub instead of raw.github), or using GitHub pages (recommended). tl;dr to users: Use Firefox for now.
Yeah, yet another disgruntled Chrome user here. I tried Vengeful as Espeon says, which is the simplest theme I could think of. No result. I don't want to download a whole new browser only for checking themes. It doesn't sound fair to me when it worked perfectly not so long ago. As in, last week tops. Hoping it gets fixed soon.
It seems that rawgithub could block you if you abuse that as a host. They are only meant to be used for samples and simpler stuff :x The thing is that the plan was to make the Theme Checker page share the script that's now used to check themes when you upload/update them in the server. Hosting it somewhere else would solve, but it would make it so they need to be updated separately.